Dan Hecht has posted comments on this change. Change subject: IMPALA-3166: basic perf support and asm dumps for codegened code ......................................................................
Patch Set 2: > I don't really have strong opinions on the disassembly format so if > people have ideas about what might be more readable I'm happy to > change it. Is the format you're using the same as what perf would show for normal code? -- To view, visit http://gerrit.cloudera.org:8080/2793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If25de61e46f4db005956686cddbd4d71a1424528 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
