Tim Armstrong has posted comments on this change. Change subject: IMPALA-3166: basic perf support and asm dumps for codegened code ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2793/2/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: Line 429: Setup any JIT listeners to process generated machine code object > Setup JIT listeners to process generated machine code object if requested ( Done Line 563: store > store what in class? did you mean to say "scoped_ptr"? but then it's not Done -- To view, visit http://gerrit.cloudera.org:8080/2793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If25de61e46f4db005956686cddbd4d71a1424528 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
