Tim Armstrong has posted comments on this change. Change subject: IMPALA-3166: basic perf support and asm dumps for codegened code ......................................................................
Patch Set 2: I'm just using the LLVM defaults (haven't figured out how to change i via the API). It looks like LLVM and perf both default to some variant of AT&T syntax, so it should be consistent. We don't have any integration between the disassembler and perf right now (perf annotate doesn't provide any hooks for that right now). -- To view, visit http://gerrit.cloudera.org:8080/2793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If25de61e46f4db005956686cddbd4d71a1424528 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
