Thomas Tauber-Marshall has posted comments on this change. Change subject: Initial structure for the C++ hiveserver2 client. ......................................................................
Patch Set 13: (4 comments) Updated to Matt's review and offline discussion: - Removed FetchResults - its adds an awkward extra level of indirection to the common case of columnar results, and supporting row oriented results isn't a priority. - Removed metadata operations - these could be redesigned in a way that makes them easier for users, but since the same basic effect can be achieved with 'show' statements we'll punt on the redesign to get this review finished. - Added GetResultSetMetadata http://gerrit.cloudera.org:8080/#/c/2645/13/src/hs2client/columnar-row-set.h File src/hs2client/columnar-row-set.h: Line 67: // Returns the value for the i-th row within this set of data for this column. : T GetData(int i) const { return data()[i]; } > Why add this now? I see why it could be useful, but I'm worried it could be Done http://gerrit.cloudera.org:8080/#/c/2645/13/src/hs2client/operation.h File src/hs2client/operation.h: Line 67: State > Here you might want to use the Operation namespace to be clear in the inter Done Line 112: // For access to the ThriftRPC for executing rpcs. > I think we chatted about adding GetResultSetMetadata in this review. Then w Done http://gerrit.cloudera.org:8080/#/c/2645/13/src/hs2client/thrift-internal.cc File src/hs2client/thrift-internal.cc: Line 104: case hs2::TOperationState::UKNOWN_STATE: : return Operation::State::UKNOWN; > lol I love that hive has this spelled wrong, but let's fix it in our enum. Done -- To view, visit http://gerrit.cloudera.org:8080/2645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7be82d5897ad6093116915b17924674c4ae508a0 Gerrit-PatchSet: 13 Gerrit-Project: hs2client Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
