Matthew Jacobs has posted comments on this change. Change subject: Initial structure for the C++ hiveserver2 client. ......................................................................
Patch Set 15: (2 comments) On second thought, maybe making char/double subclasses of ColumnDesc will be annoying to deal with. I'm going to think about it a bit more and let's chat tomorrow. http://gerrit.cloudera.org:8080/#/c/2645/15/src/hs2client/types.h File src/hs2client/types.h: Line 40: int int_value; : std::string string_value; : : // True iff this qualifier represents an int value. : bool is_int; : // True iff this qualifier represents an string value. : bool is_string; all can be const Line 107: ColumnDesc > can you give the parameters better names? Too hard to make sense of like th Yeah, let's make this a class (consistent with ColumnType) then these can all be private members and the naming is easy. -- To view, visit http://gerrit.cloudera.org:8080/2645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7be82d5897ad6093116915b17924674c4ae508a0 Gerrit-PatchSet: 15 Gerrit-Project: hs2client Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
