Matthew Jacobs has posted comments on this change. Change subject: Initial structure for the C++ hiveserver2 client. ......................................................................
Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/2645/15/src/hs2client/types.h File src/hs2client/types.h: Line 105: ColumnDesc (Adding this comment for other readers) As Thomas and I discussed, we can expose the ColumnType via helper methods e.g. GetPrimitiveType(), GetDecimalType(), etc. that assert the type matches and then return the ColumnType cast to the expected type. In the future, this would have to handle array types in a similar way anyway. -- To view, visit http://gerrit.cloudera.org:8080/2645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7be82d5897ad6093116915b17924674c4ae508a0 Gerrit-PatchSet: 15 Gerrit-Project: hs2client Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
