Taras Bobrovytsky has posted comments on this change. Change subject: Add Breakpad minidump collection script ......................................................................
Patch Set 2: (5 comments) I started the review by making some nit type comments on my own patch. http://gerrit.cloudera.org:8080/#/c/2997/2/bin/collect_minidumps.py File bin/collect_minidumps.py: Line 104: less (or equal to) Line 157: too many spaces Line 164: conf_dir Add help message. Line 165: role I think this should be renamed to role_type Line 173: add a comma here -- To view, visit http://gerrit.cloudera.org:8080/2997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85b3643133e28eca07507ac2a79acbf73128456f Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
