Lars Volker has posted comments on this change. Change subject: Add Breakpad minidump collection script ......................................................................
Patch Set 2: (1 comment) Quick remark, will to a review later. http://gerrit.cloudera.org:8080/#/c/2997/2/bin/collect_minidumps.py File bin/collect_minidumps.py: Line 152: if not os.path.isdir(result): : msg = 'Error: minidump directory "{0}" does not exist (or is not a directory).' : print >> sys.stderr, msg.format(result) > I am not sure if this calls for an exception. One scenario in which this di The directories are created during daemon startup, so if that directory does not exists then they have never been started on that node. Now we might want to run the collection script without failure in that case, so I'd also vote in favor of removing the check. -- To view, visit http://gerrit.cloudera.org:8080/2997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85b3643133e28eca07507ac2a79acbf73128456f Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes
