[email protected] has posted comments on this change.

Change subject: Add Breakpad minidump collection script
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2997/2/bin/collect_minidumps.py
File bin/collect_minidumps.py:

Line 166:       choices=['impalad', 'statestored', 'catalogd'], 
default='impalad',
The choices will be IMPALAD, STATESTORE and CATALOGSERVER


Line 181:   minidump_dir = get_minidump_dir(options.conf_dir, options.role)
        :   file_archiver = FileArchiver(source_dir=minidump_dir,
        :       max_result_size=options.max_result_size,
        :       start_time=options.start_time,
        :       end_time=options.end_time,
        :       output_file_path=options.output_file_path)
The minidump_dir now refers to /tmp/impala-minidumps location. So, the script 
needs to make sure that it goes to the right role directory to collect dumps


-- 
To view, visit http://gerrit.cloudera.org:8080/2997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85b3643133e28eca07507ac2a79acbf73128456f
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <[email protected]>
Gerrit-Reviewer: Ishaan Joshi <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Taras Bobrovytsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes

Reply via email to