Lars Volker has posted comments on this change. Change subject: IMPALA-3490: Add flag to reduce minidump size ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2990/2/be/src/util/minidump.cc File be/src/util/minidump.cc: Line 193: size_t size_limit = 1024 * FLAGS_minidump_size_limit; > Would it be prudent to have a hardcoded hard limit? Yes, I'm in favor of a hardcoded limit, given we want to replace it with a hard cap in the future. What would be a good value? -- To view, visit http://gerrit.cloudera.org:8080/2990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f3aa0df51be9f0bf0755fb288702911cdb88052 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-HasComments: Yes
