Lars Volker has posted comments on this change. Change subject: IMPALA-3490: Add flag to reduce minidump size ......................................................................
Patch Set 3: (1 comment) Thanks for the review, please see PS4. http://gerrit.cloudera.org:8080/#/c/2990/3/be/src/util/minidump.cc File be/src/util/minidump.cc: Line 192: (int64_t)FLAGS_minidump_size_limit_hint_kb > Do we follow the Google style guide? If so, then use C++ style cast instea Done. I thought we used C style casts, but a look at other code files showed we use C++ style indeed. -- To view, visit http://gerrit.cloudera.org:8080/2990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f3aa0df51be9f0bf0755fb288702911cdb88052 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-HasComments: Yes
