Lars Volker has posted comments on this change. Change subject: IMPALA-3490: Add flag to reduce minidump size ......................................................................
Patch Set 2: (4 comments) Thanks for the reviews, see PS3. http://gerrit.cloudera.org:8080/#/c/2990/2/be/src/common/global-flags.cc File be/src/common/global-flags.cc: Line 79: DEFINE_int32(minidump_size_limit, 20480, "Size limit for minidump files in KB. If a " > Should we include the measurement unit minidump_size_limit_kb? Done http://gerrit.cloudera.org:8080/#/c/2990/2/be/src/util/minidump.cc File be/src/util/minidump.cc: Line 192: { > combine these two lines Done Line 193: size_t size_limit = 1024 * FLAGS_minidump_size_limit; > Yes, I'm in favor of a hardcoded limit, given we want to replace it with a I noticed, that setting a hardcoded limit is going to make testing very difficult, as we don't seem to have a way to spin up an excessive number of threads and trigger the cap. Thus I'd say it's easier to keep the configurable option. http://gerrit.cloudera.org:8080/#/c/2990/2/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: Line 142: def trigger_single_minidump_and_get_size(): > Does this method absolutely need to be nested? (I generally find it hard t Done -- To view, visit http://gerrit.cloudera.org:8080/2990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f3aa0df51be9f0bf0755fb288702911cdb88052 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-HasComments: Yes
