Lars Volker has posted comments on this change. Change subject: IMPALA-3489: Add script to extract breakpad symbols from binaries ......................................................................
Patch Set 3: (1 comment) Thanks for the review, see PS4. http://gerrit.cloudera.org:8080/#/c/2961/3/bin/dump_breakpad_symbols.py File bin/dump_breakpad_symbols.py: Line 167: tmp_len = len(tmp_dir.split(os.sep)) > It seems like this variable is not used anywhere. Done -- To view, visit http://gerrit.cloudera.org:8080/2961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ee0972efcb50609407b04cd6f4309b244a84861 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
