Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3489: Add script to extract breakpad symbols from binaries ......................................................................
Patch Set 3: (2 comments) I tested some combinations and they seem to work as expected. I have one question though, shouldn't this go into the aux-repo? http://gerrit.cloudera.org:8080/#/c/2961/3/bin/dump_breakpad_symbols.py File bin/dump_breakpad_symbols.py: Line 29: Goodle Typo Line 37: # ./dump_breakpad_symbols -d /tmp/syms -r tmp/impala-2.5.0+cdh5.7.0+0-1.cdh5.7.0.p0.147.el6.x86_64.rpm -s tmp/impala-debuginfo-2.5.0+cdh5.7.0+0-1.cdh5.7.0.p0.147.el6.x86_64.rpm long lines, here and elsewhere in this file. -- To view, visit http://gerrit.cloudera.org:8080/2961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ee0972efcb50609407b04cd6f4309b244a84861 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
