Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3489: Add script to extract breakpad symbols from binaries ......................................................................
Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/2961/4/bin/dump_breakpad_symbols.py File bin/dump_breakpad_symbols.py: Line 76: breakpad nit: capital B Line 100: Path to a directory containing results : from an impala build, e.g. be/build/debug I think this will make the help message look strange, "from an impala..." will be strangely indented. Line 112: # Post processing checks Maybe also verify that, for example, if binary_files were specified then stdin_files and rpm is false? Line 126: if e.errno != errno.EEXIST: I think you should also check that path is a directory. Maybe rewrite like this: if e.errno != errno.EEXIST or not os.path.isdir(path) Line 142: """Check whether 'path' is an ELF file.""" How about adding the is_file check here? Line 201: return [] The script should not get to this point, maybe some kind of error message should be given? Line 246: success = True maybe change this to status = 0, then after the loop you can do: sys.exit(status) -- To view, visit http://gerrit.cloudera.org:8080/2961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ee0972efcb50609407b04cd6f4309b244a84861 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
