Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3535: Ignore invalid per-pool default query options ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3056/1/be/src/service/query-options.cc File be/src/service/query-options.cc: Line 432: ignore_invalid_options > rather than passing this in, maybe it'd be cleaner to just make this routin Hmm, though it's harder to deal with multiple errors in the case where it would want to ignore. If you'd prefer that I'm happy to change it. Line 451: if (ignore_invalid_options) { > this doesn't look right. shouldn't it check !s.ok() too? why don't the admi Yeah it should be there. It wasn't caught by the tests bc it turns out not to have any observable test effect (only logging). If ignore=true we would continue either way but logging for each key-value pair. After fixing this it will only log at the right times. -- To view, visit http://gerrit.cloudera.org:8080/3056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If04733b775963091b0314c65286df126fd812358 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
