Dan Hecht has posted comments on this change. Change subject: IMPALA-3535: Ignore invalid per-pool default query options ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3056/1/be/src/service/query-options.cc File be/src/service/query-options.cc: Line 432: ignore_invalid_options > Hmm, though it's harder to deal with multiple errors in the case where it w Not sure I follow. MergeStatus can deal with multiple errors and pass back a single status, right? Line 451: if (ignore_invalid_options) { > Yeah it should be there. It wasn't caught by the tests bc it turns out not The test to catch this bug is to add an incorrect query option key=option to the process startup (or wherever else we expect to error out) and verify we error out. or am I misunderstanding the current behavior? -- To view, visit http://gerrit.cloudera.org:8080/3056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If04733b775963091b0314c65286df126fd812358 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
