Dan Hecht has posted comments on this change. Change subject: IMPALA-3535: Ignore invalid per-pool default query options ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3056/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 738: VLOG_QUERY << "Ignoring errors parsing query options: " << status.GetDetail(); would be nice to indicate that these are from the pool config: Ignoring errors parsing admission control pool query options: or similar. http://gerrit.cloudera.org:8080/#/c/3056/2/tests/query_test/test_query_opts.py File tests/query_test/test_query_opts.py: Line 60: execute_statement_req.statement = "set foo=bar;" why is the SET command tested with HS2 specifically? Isn't it equally valid to test in beeswax? (and in fact, isn't the set.test file doing that?) -- To view, visit http://gerrit.cloudera.org:8080/3056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If04733b775963091b0314c65286df126fd812358 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
