Dan Hecht has posted comments on this change. Change subject: Impala-3286: Prefetching For Phj Probing. ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2959/3/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 151: int limit = FIXED_LEN_BUFFER_LIMIT) : > It's not a hard limit - it's possible to create a RowBatch with arbitrary c But isn't it a correctness issue to use it like this? i.e. the entire row batch might not be iterated when not passing a limit. -- To view, visit http://gerrit.cloudera.org:8080/2959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib42b93d99d09c833571e39d20d58c11ef73f3cc0 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
