Tim Armstrong has posted comments on this change. Change subject: Impala-3286: Prefetching For Phj Probing. ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/2959/4/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 151: FIXED_LEN_BUFFER_LIMIT > I don't think this is always the upper bound on row-batches. Tim, can you c Oops, looks like i had a comment on an old patch set that I didn't flush out. I already talked to Michael offline about this anyway - INT_MAX is the only upper bound. Line 155: + limit > also i don't see why we'd add this to row_idx. why does it matter where you Limit is the # of rows you'll iterate over. The macro comment below explains, but we should also explain what 'limit' means here. -- To view, visit http://gerrit.cloudera.org:8080/2959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib42b93d99d09c833571e39d20d58c11ef73f3cc0 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
