Tim Armstrong has posted comments on this change. Change subject: Impala-3286: Prefetching For Phj Probing. ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2959/4/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 151: FIXED_LEN_BUFFER_LIMIT > INT_MAX will cause an overflow since it's added to row_idx. Yeah, good point, we should just make limit default to -1 and handle the no-limit case separately from the limit case. (or have separate constructors for the two cases). -- To view, visit http://gerrit.cloudera.org:8080/2959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib42b93d99d09c833571e39d20d58c11ef73f3cc0 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
