Lars Volker has posted comments on this change. Change subject: IMPALA-3489: Add script to extract breakpad symbols from binaries ......................................................................
Patch Set 5: (1 comment) Thanks Michael for the review. Please see PS6. Can someone +2 this? http://gerrit.cloudera.org:8080/#/c/2961/5/bin/dump_breakpad_symbols.py File bin/dump_breakpad_symbols.py: Line 227: tmp_fd, tmp_file = tempfile.mkstemp(dir=out_dir, suffix='.sym') > This file never gets closed. It does, I added a comment (and verified with a test script that it does get closed). -- To view, visit http://gerrit.cloudera.org:8080/2961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ee0972efcb50609407b04cd6f4309b244a84861 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
