Dan Hecht has posted comments on this change. Change subject: IMPALA-3286: Prefetching for PHJ probing. ......................................................................
Patch Set 5: (5 comments) Started on this before you uploaded patchset 6. here's the first set of comments and i'll continue on patchset 6. http://gerrit.cloudera.org:8080/#/c/2959/5/be/src/exec/hash-table.h File be/src/exec/hash-table.h: Line 209: consumed read. (it's not valid during write mode, right?) Line 263: is null This still seems misleading to me. Would this be accurate: ... has a null value and nulls are not considered during the current phase (either build or probe). Line 266: row is NULL same Line 275: values this should be singular still. this give you back the location of one value in the row: Returns a pointer to the value of the i-th expression for the current row. Line 279: expression values at 'expr_idx' same wording as above. -- To view, visit http://gerrit.cloudera.org:8080/2959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib42b93d99d09c833571e39d20d58c11ef73f3cc0 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
