Dan Hecht has posted comments on this change. Change subject: IMPALA-1583: Simplify PartitionedHashJoinNode::ProcessProbeBatch() ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/2893/8/be/src/exec/partitioned-hash-join-node-ir.cc File be/src/exec/partitioned-hash-join-node-ir.cc: Line 352: switch (join_op) { > since this is all cross-compiled, why not extend what tim did for bool cons Yes, Tim and I had talked about getting rid of these templates, but for after the release. -- To view, visit http://gerrit.cloudera.org:8080/2893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2091bdf97ab34c5cdc84e84394c579a5b36afc0 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
