Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3332: Free local allocations in sorter.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3116/1/testdata/workloads/functional-query/queries/QueryTest/spilling.test
File testdata/workloads/functional-query/queries/QueryTest/spilling.test:

Line 397: set max_block_mgr_memory=4m;
> I noticed that with 4M as the limit, the sort node actually consumes up to 
If it's 4M it probably forces it to spill. Maybe we need to free local 
allocations in the merger too?


-- 
To view, visit http://gerrit.cloudera.org:8080/3116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I941729b4836e5dbb827d4313a0b45bc5df2fa8e1
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Ho <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to