Dan Hecht has posted comments on this change. Change subject: IMPALA-3332: Free local allocations in sorter. ......................................................................
Patch Set 5: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/3116/5/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 945: if (UNLIKELY(state_->is_cancelled())) return Status::CANCELLED; RETURN_IF_CANCELLED(state_); Line 972: if (UNLIKELY(state_->is_cancelled())) return Status::CANCELLED; RETURN_IF_CANCELLED Line 1004: if (UNLIKELY(state_->is_cancelled())) return Status::CANCELLED; RETURN_IF_CANCELLED -- To view, visit http://gerrit.cloudera.org:8080/3116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I941729b4836e5dbb827d4313a0b45bc5df2fa8e1 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
