Tim Armstrong has posted comments on this change. Change subject: IMPALA-3332: Free local allocations in sorter. ......................................................................
Patch Set 4: Code-Review+1 (1 comment) Thanks for fixing this, I forgot about the merger. http://gerrit.cloudera.org:8080/#/c/3116/4/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 269: TupleIterator() { } Can you initialize this to some invalid values (NULL, -1, etc) to make sure we fail hard if we accidentally dereference it. -- To view, visit http://gerrit.cloudera.org:8080/3116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I941729b4836e5dbb827d4313a0b45bc5df2fa8e1 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
