Alex Behm has posted comments on this change. Change subject: IMPALA-3314/IMPALA-3513: Fix querying tables/partitions altered to Avro format ......................................................................
Patch Set 1: (2 comments) new patch? http://gerrit.cloudera.org:8080/#/c/3136/1/fe/src/main/java/com/cloudera/impala/catalog/HdfsTable.java File fe/src/main/java/com/cloudera/impala/catalog/HdfsTable.java: Line 1010: if (loadTableSchema) loadSchema(client, msTbl); can we do this? if (loadTableSchema) { loadSchema(client, msTbl); setAvroSchema(client, msTbl); } that way the schema related stuff happens in a single place http://gerrit.cloudera.org:8080/#/c/3136/1/testdata/workloads/functional-query/queries/QueryTest/avro-stale-schema.test File testdata/workloads/functional-query/queries/QueryTest/avro-stale-schema.test: Line 3: drop table if exists functional_avro_snap.alltypesagg_staleschema > Per my understanding of unique db fixture, it is not yet supported for .tes That's correct, but doesn't matter in this case. Just do this: def test_avro_stale_schema(self, vector, unique_database): self.run_test_case('QueryTest/avro-stale-schema', vector, unique_database) then in your .test file CREATE EXTERNAL TABLE alltypesagg_staleschema ... the table will be created in the unique database because you gave a "use_db" param to run_test_case() just use unqualified table references everywhere in this .test and you are good -- To view, visit http://gerrit.cloudera.org:8080/3136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09262d3a7b85a2263c721f3beafd0cab2a1bdf4b Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-HasComments: Yes
