Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3314/IMPALA-3513: Fix querying tables/partitions altered 
to Avro format
......................................................................


Patch Set 1:

(2 comments)

Sorry forgot to upload the patch. Here it is

http://gerrit.cloudera.org:8080/#/c/3136/1/fe/src/main/java/com/cloudera/impala/catalog/HdfsTable.java
File fe/src/main/java/com/cloudera/impala/catalog/HdfsTable.java:

Line 1010:       if (loadTableSchema) loadSchema(client, msTbl);
> can we do this?
I didn't do it because setAvroSchema() depends on loading the partition data 
(which set "hasAvroData_" flag). So moved post partition loading calls.


http://gerrit.cloudera.org:8080/#/c/3136/1/testdata/workloads/functional-query/queries/QueryTest/avro-stale-schema.test
File 
testdata/workloads/functional-query/queries/QueryTest/avro-stale-schema.test:

Line 3: drop table if exists functional_avro_snap.alltypesagg_staleschema
> That's correct, but doesn't matter in this case. Just do this:
Nice, I didn't know this trick. Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/3136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09262d3a7b85a2263c721f3beafd0cab2a1bdf4b
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-HasComments: Yes

Reply via email to