Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3314/IMPALA-3513: Fix querying tables/partitions altered to Avro format ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/3136/2/fe/src/main/java/com/cloudera/impala/catalog/HdfsTable.java File fe/src/main/java/com/cloudera/impala/catalog/HdfsTable.java: Line 1260: if (HdfsFileFormat.fromJavaClassName(inputFormat) == HdfsFileFormat.AVRO > now we really don't need this first check, right? I think we still need this check. Reason, if you see the call to updatePartitionsFromHms() (which calls loadPartitions...) is only called if (msTbl.getPartitionKeysSize() == 0).. which is true only for "actually" partitioned tables. if (msTbl.getPartitionKeysSize() == 0) { if (loadFileMetadata) updateUnpartitionedTableFileMd(); } else { updatePartitionsFromHms(client, partitionsToUpdate, loadFileMetadata); } http://gerrit.cloudera.org:8080/#/c/3136/2/testdata/workloads/functional-query/queries/QueryTest/avro-stale-schema.test File testdata/workloads/functional-query/queries/QueryTest/avro-stale-schema.test: Line 3: drop table if exists alltypesagg_staleschema > no need for this due to unique_db fixture, remove Done Line 18: ) LOCATION 'hdfs://localhost:20500//test-warehouse/alltypesaggmultifilesnopart_avro_snap' > nit: move LOCATIOn to next line Done http://gerrit.cloudera.org:8080/#/c/3136/2/tests/query_test/test_avro_schema_resolution.py File tests/query_test/test_avro_schema_resolution.py: Line 46: """ Test for IMPALA-3314 and IMPALA-3513. Impalad shouldn't crash with stale avro > remove first space Done Line 51: # Invalidating metadata should trigger a reload and the schema should set properly. > Invalidating metadata should cause the Avro schema to be properly set upon Done -- To view, visit http://gerrit.cloudera.org:8080/3136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09262d3a7b85a2263c721f3beafd0cab2a1bdf4b Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-HasComments: Yes
