Jim Apple has posted comments on this change. Change subject: Refactor RuntimeState and ExecEnv dependencies ......................................................................
Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/3108/3/be/src/runtime/runtime-filter-bank.h File be/src/runtime/runtime-filter-bank.h: Line 1: // Copyright 2016 Cloudera Inc. Is this file changed from the file it was copied from (excluding declaration and naming changes induced by the header changes)? http://gerrit.cloudera.org:8080/#/c/3108/3/be/src/runtime/runtime-filter.cc File be/src/runtime/runtime-filter.cc: Line 39 Why is query_ctx_ not being initialized any more? Line 146 Can you help me undersyand why this and line 149 are changing? Line 40: RuntimeFilterBank::RuntimeFilterBank(const TQueryCtx& query_ctx, RuntimeState* state) Shouldn't these definitions be moved to runtime-filter-bank.cc? http://gerrit.cloudera.org:8080/#/c/3108/3/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: Line 362: boost::scoped_ptr<RuntimeFilterBank> filter_bank_; What is the likelihood of a performance regression from this extra indirection? http://gerrit.cloudera.org:8080/#/c/3108/3/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: Line 1: // Copyright 2016 Cloudera Inc. Is this file changed from the file it was copied from (excluding declaration and naming changes induced by the header changes)? -- To view, visit http://gerrit.cloudera.org:8080/3108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b246ad9c3681d649e7bfc969c7fa885c6242d84 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
