Tim Armstrong has posted comments on this change. Change subject: Refactor RuntimeState and ExecEnv dependencies ......................................................................
Patch Set 3: (4 comments) I'm working on making the requested changes but I thought I'd respond now. Will post an updated patch soon. http://gerrit.cloudera.org:8080/#/c/3108/3/be/src/runtime/runtime-filter-bank.h File be/src/runtime/runtime-filter-bank.h: Line 1: // Copyright 2016 Cloudera Inc. > I left the comment on line 1 only because that is the default line for gerr The only real change was deleting the query_ctx_ member. http://gerrit.cloudera.org:8080/#/c/3108/3/be/src/runtime/runtime-filter.cc File be/src/runtime/runtime-filter.cc: Line 40: RuntimeFilterBank::RuntimeFilterBank(const TQueryCtx& query_ctx, RuntimeState* state) > I am OK with that awkwardness. Will do http://gerrit.cloudera.org:8080/#/c/3108/3/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: Line 362: boost::scoped_ptr<RuntimeFilterBank> filter_bank_; > High-level, what is the relationship between filter_bank_ and the FilterCon FilterContext holds all the relevant data structures about a filter required by the exec node: counters, a pointer to the global RuntimeFilter object, a pointer to the bloom filter, etc. The FilterContext is set up during the prepare phase. The filter is looked up in the RuntimeFilterBank and a pointer to it is cached in the FilterContext. The cached pointer is used during execution, so it doesn't need to do lookups in RuntimeFilterBank. http://gerrit.cloudera.org:8080/#/c/3108/3/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: Line 1: // Copyright 2016 Cloudera Inc. > I can change back (I assume if there weren't substantial changes, you mean To answer the original question - no - it was a copy/paste then just had to unindent and fix prefix the class names with RuntimeProfile:: -- To view, visit http://gerrit.cloudera.org:8080/3108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b246ad9c3681d649e7bfc969c7fa885c6242d84 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
