Jim Apple has posted comments on this change. Change subject: Refactor RuntimeState and ExecEnv dependencies ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3108/3/be/src/runtime/runtime-filter-bank.h File be/src/runtime/runtime-filter-bank.h: Line 1: // Copyright 2016 Cloudera Inc. > Not substantially. I can change back to 2012 (not sure what the rule of thu I left the comment on line 1 only because that is the default line for gerrit comments. I have no opinion on the copyright date. http://gerrit.cloudera.org:8080/#/c/3108/3/be/src/runtime/runtime-filter.cc File be/src/runtime/runtime-filter.cc: Line 40: RuntimeFilterBank::RuntimeFilterBank(const TQueryCtx& query_ctx, RuntimeState* state) > We could do something like that. The only awkward thing would be that runti I am OK with that awkwardness. http://gerrit.cloudera.org:8080/#/c/3108/3/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: Line 362: boost::scoped_ptr<RuntimeFilterBank> filter_bank_; > It looks like this is not referenced during actual query processing. In the High-level, what is the relationship between filter_bank_ and the FilterContexts? -- To view, visit http://gerrit.cloudera.org:8080/3108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b246ad9c3681d649e7bfc969c7fa885c6242d84 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
