Dan Hecht has posted comments on this change. Change subject: IMPALA-1633: GetOperationStatus should set errorMessage and sqlState ......................................................................
Patch Set 3: > (8 comments) > > Updated to the reviews. > > I also removed QueryExecState::set_query_state as its not being > used anywhere, and removing it makes it easier to trace through all > of the code paths where query_state_ gets set, and I added some > comments clarifying some of our behavior around query_state_/query_status_. > > I'm almost certain that query-exec-state.cc:846 (query_state_ = > QueryState::EXCEPTION;) could be removed, as it should be > impossible for query_state_ to not already be EXCEPTION if you > reach this line, and doing so would further clarify our behavior, > but its a riskier change so I left it for now (I did try changing > it to a DCHECK and running all of the tests locally, and nothing > failed) I think you should go ahead and do that cleanup. At the beginning of the if block you could add: DCHECK(!cause->ok()); and then at the end add the DCHECK you mentioned. It's a good cleanup, and it'd be good to find out if we're passing OK to Cancel() somehow now or in the future (and auditing the code would be good to verify). -- To view, visit http://gerrit.cloudera.org:8080/3094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb792f88286779fcf2ce409828de818bc4e80bed Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: No
