Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1633: GetOperationStatus should set errorMessage and sqlState ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3094/5/be/src/service/query-exec-state.cc File be/src/service/query-exec-state.cc: Line 674: UpdateQueryState > I think it might be worth having this DCHECK if query_state is an exception Done http://gerrit.cloudera.org:8080/#/c/3094/5/tests/hs2/hs2_test_suite.py File tests/hs2/hs2_test_suite.py: Line 213: HS2TestSuite.check_response(get_operation_status_resp, expected_status_code) > I suspect this may be more confusing than it's worth. Imagine someone adds Done http://gerrit.cloudera.org:8080/#/c/3094/5/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: Line 175: get_operation_status_resp.sqlState > do we know what this will be? Done -- To view, visit http://gerrit.cloudera.org:8080/3094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb792f88286779fcf2ce409828de818bc4e80bed Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
