Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1633: GetOperationStatus should set errorMessage and sqlState ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/3094/6/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: Line 945: DCHECK(!exec_state->query_status().ok()); If we're upholding our claim in query-exec-state.h "We enforce the invariant that query_status_ is not OK iff query_state_ is EXCEPTION, given that lock_ is held.", then we should be able to also DCHECK the converse, i.e. if operation_state != error, then query_status() is OK, right? http://gerrit.cloudera.org:8080/#/c/3094/6/be/src/service/query-exec-state.h File be/src/service/query-exec-state.h: Line 109: UpdateQueryState So now that I re-read this, I think it's misleading to keep the same name while this only can be used for non-error states. While "UpdateNonErrorQueryState()" sounds bad, I think we should better expose the behavior that this is only for Error states. I think someone adding code could easily use this function without thinking. -- To view, visit http://gerrit.cloudera.org:8080/3094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb792f88286779fcf2ce409828de818bc4e80bed Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
