Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3577, IMPALA-3486: Partitions on multiple filesystems breaks with S3_SKIP_INSERT_STAGING ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/3146/7/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: Line 298: RETURN_IF_ERROR(HdfsFsCache::instance()->GetConnection( Brought the GetConnection() here because this is the right place to get it. Previously it had an edge case where we would get the wrong connection for the filesystem for multi-FS partitioned tables. Line 311: VLOG_FILE << "hdfsOpenFile() file=" << tmp_hdfs_file_name_cstr; Moved this check to just after we open the file instead of after we GetPathInfo(). -- To view, visit http://gerrit.cloudera.org:8080/3146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib13b610eb9efb68c83894786cea862d7eae43aa7 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
