Dan Hecht has posted comments on this change. Change subject: IMPALA-3577, IMPALA-3486: Partitions on multiple filesystems breaks with S3_SKIP_INSERT_STAGING ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3146/7/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: Line 298: RETURN_IF_ERROR(HdfsFsCache::instance()->GetConnection( > Brought the GetConnection() here because this is the right place to get it. it's not obvious why this is correct. What's wrong with the old location, which seems more logical given that's where the output partition is being initialized? Doesn't this happen once per file, whereas we should only need to get the connection once per partition, no? -- To view, visit http://gerrit.cloudera.org:8080/3146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib13b610eb9efb68c83894786cea862d7eae43aa7 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
