Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-2336: Ignore trailing comments in non-interactive mode ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3169/1/shell/impala_shell.py File shell/impala_shell.py: Line 1171: # Remove trailing comments, if any > I don't think we want to do this, it means that we're reliant on the module Isn't the SQL comment defined as per SQL-92 standard, which Impala follows? (-- for single line and C-style for multiline). I'm hoping sqlparse is SQL-92 compliant, although I couldn't find it on their website. -- To view, visit http://gerrit.cloudera.org:8080/3169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I723763ef7eedd03cf22058fadf06e9673a0d94d2 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-HasComments: Yes
