Casey Ching has posted comments on this change. Change subject: IMPALA-2336: Ignore trailing comments in non-interactive mode ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3169/2/shell/impala_shell.py File shell/impala_shell.py: Line 1171: # Remove trailing comments, if any Please explain why this is needed Line 1172: if query_list and not sqlparse.format(query_list[-1], strip_comments=True).strip("\n"): Why only look at the last item in the list? Why not pop all the empty items off? http://gerrit.cloudera.org:8080/#/c/3169/2/tests/shell/test_file_comments.sql File tests/shell/test_file_comments.sql: Line 21: */ Doesn't the comment end at the line above? I think this line should be part of the query, is that what you are thinking too? -- To view, visit http://gerrit.cloudera.org:8080/3169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I723763ef7eedd03cf22058fadf06e9673a0d94d2 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-HasComments: Yes
