Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-2336: Ignore trailing comments in non-interactive mode ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3169/1/shell/impala_shell.py File shell/impala_shell.py: Line 1171: # Remove trailing comments, if any > It generally is, and we used it for a while to filter out comments. However Makes sense. But, I think this specific case of trailing comments is annoying to the customers. The reason I'm submitting this patch is that one of our customers have 100s of scripts with such trailing comments and they say they can't go and edit each one of them. I think its a decent ask. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/3169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I723763ef7eedd03cf22058fadf06e9673a0d94d2 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-HasComments: Yes
