Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2459: Implement next_day date/time UDF ......................................................................
Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/1943/7/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 351: void TEST_UDF_NEXT_DAY(){ follow standard naming conventions Line 363: TestTimestampValue("next_day('2016-05-01','Saturday')", what happened to friday? Line 365: TestTimestampValue("next_day('2016-05-01','Sunday')", you already have that http://gerrit.cloudera.org:8080/#/c/1943/7/be/src/exprs/timestamp-functions.h File be/src/exprs/timestamp-functions.h: Line 152: /// Similar examples are: also drop this and the following line -- To view, visit http://gerrit.cloudera.org:8080/1943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2721d236c096639a9e7d2df8a45ca888c6b3e83e Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
