Lars Volker has posted comments on this change.
Change subject: IMPALA-2459: Implement next_day date/time UDF
......................................................................
Patch Set 11:
Hi Youwei, I rebased this change to submit it. However the tests failed:
./be/build/debug/exprs/expr-test --gtest_filter="*TimestampFunction*"
Running without optimization passes.
Running without codegen
Note: Google Test filter = *TimestampFunction*
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ExprTest
[ RUN ] ExprTest.TimestampFunctions
be/src/exprs/expr-test.cc:239: Failure
Value of: expect_error
Actual: false
Expected: true
stmt: select next_day('2016-05-01','Sunday')
error: 42000: AnalysisException: Database does not exist: default
unknown file: Failure
C++ exception with description "Year is out of valid range: 1400..10000" thrown
in the test body.
[ FAILED ] ExprTest.TimestampFunctions (6898 ms)
[----------] 1 test from ExprTest (6898 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (6898 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ExprTest.TimestampFunctions
1 FAILED TEST
Can you please have a look? Thanks, Lars
--
To view, visit http://gerrit.cloudera.org:8080/1943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2721d236c096639a9e7d2df8a45ca888c6b3e83e
Gerrit-PatchSet: 11
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Youwei Wang <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Youwei Wang <[email protected]>
Gerrit-HasComments: No
