Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2459: Implement next_day date/time UDF ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/1943/5/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 4301: // Explicit timestamp conversion tests > Following tests are testing dates in customized formats which can be conver please leave explanatory comment in code http://gerrit.cloudera.org:8080/#/c/1943/5/be/src/exprs/timestamp-functions-ir.cc File be/src/exprs/timestamp-functions-ir.cc: Line 582 that doesn't mean you should remove all blank lines. please put them back. -- To view, visit http://gerrit.cloudera.org:8080/1943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2721d236c096639a9e7d2df8a45ca888c6b3e83e Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
