Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-2336: Ignore trailing comments in non-interactive mode ......................................................................
IMPALA-2336: Ignore trailing comments in non-interactive mode This patch trims trailing comments while parsing queries in non-interactive mode. Users usually have comments in the end of the script which should be ignored. Without this patch, the script fails with an exception since it expects a valid SQL. The behavior however remains the same with interactive mode. Change-Id: I723763ef7eedd03cf22058fadf06e9673a0d94d2 Reviewed-on: http://gerrit.cloudera.org:8080/3169 Reviewed-by: Casey Ching <[email protected]> Tested-by: Internal Jenkins --- M shell/impala_shell.py M tests/shell/test_file_comments.sql 2 files changed, 23 insertions(+), 1 deletion(-) Approvals: Casey Ching: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I723763ef7eedd03cf22058fadf06e9673a0d94d2 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Ishaan Joshi <[email protected]>
