Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-2336: Ignore trailing comments in non-interactive mode
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3169/4/shell/impala_shell.py
File shell/impala_shell.py:

Line 1172:   # input at query boundaries and associates the query only with 
preceeding comments
> preceding (single e)
Ah sorry, typo! Done.


Line 1182:   # and throws an exception. We figure out such trailing comment 
(without SQL) and remove
> We figure out ... ->
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I723763ef7eedd03cf22058fadf06e9673a0d94d2
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
Gerrit-Reviewer: Ishaan Joshi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to