Alex Behm has posted comments on this change. Change subject: IMPALA-2336: Ignore trailing comments in non-interactive mode ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3169/3/shell/impala_shell.py File shell/impala_shell.py: Line 1172: # input at query boundaries and associates the query with the comments that written only associates the query only with preceding comments (following comments are associated with the next query). Line 1174: # consider the following input, input: (colon instead of comma) http://gerrit.cloudera.org:8080/#/c/3169/3/tests/shell/test_file_comments.sql File tests/shell/test_file_comments.sql: Line 17: -- comment within-comment remove -- To view, visit http://gerrit.cloudera.org:8080/3169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I723763ef7eedd03cf22058fadf06e9673a0d94d2 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-HasComments: Yes
