Lars Volker has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 1:

I looked at glog 0.3.3 and 0.3.4, but neither contains the change we need, so 
we would need to pick it anyways.

This largely affects debug builds, so having it in 5.8 would allow us to make 
use of breakpad in tests running debug builds, such as stress tests. However it 
does not look critical in terms of the released bits.

-- 
To view, visit http://gerrit.cloudera.org:8080/3285
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97f528f3190b2f09cd2a135551c618d0e501b7a0
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-HasComments: No

Reply via email to