Lars Volker has submitted this change and it was merged. Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps ......................................................................
IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps When hitting a DCHECK/CHECK the daemons do not write minidumps. This is caused by glog's own stack unwinding mechanism, which catches SIGABRT and removes all other handlers before aborting. This patch backports a change from glog, which only resets the SIGABRT handler, if it is the one installed by glog itself. https://github.com/google/glog/commit/cda16b3443e2d6ef88cdbbe10b9a11adea6f33fe Testing: Did a local build and made sure that both the DCHECK error are logged and minidumps are written. Change-Id: I97f528f3190b2f09cd2a135551c618d0e501b7a0 --- M buildall.sh A source/glog/glog-0.3.2-patches/0002-Preserve-custom-signal-handler-for-dcheck.patch 2 files changed, 87 insertions(+), 0 deletions(-) Approvals: Lars Volker: Verified Matthew Jacobs: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97f528f3190b2f09cd2a135551c618d0e501b7a0 Gerrit-PatchSet: 2 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]>
