Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps ......................................................................
Patch Set 1: (1 comment) I didn't look at the glog delta itself. Let me know if you'd like me to. http://gerrit.cloudera.org:8080/#/c/3285/1/buildall.sh File buildall.sh: PS1, Line 138: GFLAGS_VERSION=2.0 GLOG_VERSION=0.3.2-p2 $SOURCE_DIR/source/glog/build.sh Rather than editing this line, I'd leave the existing call to build with p1 in place and then have a line below which does this for p2. You can see we do this for other patch versions elsewhere. Right now we have buildall.sh literally build ALL (all released versions at least). It's a bit silly, but this is kind of the source of truth (rather than the s3 bucket which is just the result of these scripts) for all binaries anyone might need from native-toolchain. That's bad for other reasons, but all of this is a longer conversation. -- To view, visit http://gerrit.cloudera.org:8080/3285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97f528f3190b2f09cd2a135551c618d0e501b7a0 Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
